Skip to content

Pin VS-compatible package versions for local dev#20016

Open
abonie wants to merge 1 commit into
dotnet:mainfrom
abonie:pin-vs-compat-packages
Open

Pin VS-compatible package versions for local dev#20016
abonie wants to merge 1 commit into
dotnet:mainfrom
abonie:pin-vs-compat-packages

Conversation

@abonie

@abonie abonie commented Jul 1, 2026

Copy link
Copy Markdown
Member

Local (non-CI) workaround: the Roslyn/MSBuild package versions that flow
in via Maestro run ahead of what ships in the currently-released
Visual Studio, causing assembly version skew
(see #18766).

For local builds we pin these back to the last VS-compatible versions, CI keeps the Maestro-provided versions.
Override AFTER the import so these win over the eager XxxVersion aliases

Local (non-CI) workaround: the Roslyn/MSBuild package versions that flow
 in via Maestro run ahead of what ships in the currently-released
 Visual Studio, causing assembly version skew
 (see dotnet#18766).

For local builds we pin these back to the last VS-compatible versions,
CI keeps the Maestro-provided versions.
Override AFTER the import so these win over the eager XxxVersion aliases
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ No release notes required

@github-actions github-actions Bot added ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Restore Tooling check: PR touches NuGet packages or feeds labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore
Affects-Build-Infra: modifies eng/Versions.props (MSBuild property file)
Affects-Restore: changes package version properties used during restore

Generated by PR Tooling Safety Check · opus46 4.6M ·

@abonie
abonie requested a review from T-Gro July 1, 2026 14:30
@abonie

abonie commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

@kerams Could you try if this resolves #18766 for you?

@kerams

kerams commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

If I don't need to do anything special after pulling, it doesn't. Maybe I'll need to do a full git clean...

@kerams

kerams commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

The problem is otelExport in DebugHelpers.fs throwing exceptions. If I comment out the body, the vsix is loaded fine in an experimental instance.

System.TypeLoadException: 'Could not load type 'OpenTelemetry.Metrics.MetricReaderHistogramAggregation' from assembly 'OpenTelemetry, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c'.'

Edit: And now it stopped working again...

@brianrourkeboll

Copy link
Copy Markdown
Contributor

@abonie

@kerams Could you try if this resolves #18766 for you?

Building and deploying the latest Roslyn and including the change from this PR does make it work again for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Restore Tooling check: PR touches NuGet packages or feeds

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

3 participants